fix: check_and_call_extract_file uses the first matching method and options, instead of the first matching method and last matching options
Otherwise, if I want to use a different method for one file AND use options, I can't do, for example:
[myextractor: path/file.py]
myoption = myvalue
[python: path/**.py]
The current code will match path/file.py to myextractor, but it'll use the empty options from python...
I would love to, but it's very hard to figure out where/how to test this. Basically, I'd need some scaffolding to be able to provide a configuration file, source files and a custom extractor and test whether the output is as expected.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.45%. Comparing base (
cfdbc63) to head (4856358). Report is 1 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #1121 +/- ##
==========================================
+ Coverage 91.28% 91.45% +0.17%
==========================================
Files 27 27
Lines 4624 4625 +1
==========================================
+ Hits 4221 4230 +9
+ Misses 403 395 -8
| Flag | Coverage Δ | |
|---|---|---|
| macos-14-3.10 | 90.22% <100.00%> (+0.17%) |
:arrow_up: |
| macos-14-3.11 | 90.16% <100.00%> (+0.17%) |
:arrow_up: |
| macos-14-3.12 | 90.37% <100.00%> (+0.17%) |
:arrow_up: |
| macos-14-3.13 | 90.37% <100.00%> (+0.17%) |
:arrow_up: |
| macos-14-3.8 | 90.15% <100.00%> (+0.17%) |
:arrow_up: |
| macos-14-3.9 | 90.15% <100.00%> (+0.17%) |
:arrow_up: |
| macos-14-pypy3.10 | 90.22% <100.00%> (+0.17%) |
:arrow_up: |
| ubuntu-24.04-3.10 | 90.24% <100.00%> (+0.17%) |
:arrow_up: |
| ubuntu-24.04-3.11 | 90.18% <100.00%> (+0.17%) |
:arrow_up: |
| ubuntu-24.04-3.12 | 90.40% <100.00%> (+0.17%) |
:arrow_up: |
| ubuntu-24.04-3.13 | 90.40% <100.00%> (+0.17%) |
:arrow_up: |
| ubuntu-24.04-3.8 | 90.17% <100.00%> (+0.17%) |
:arrow_up: |
| ubuntu-24.04-3.9 | 90.17% <100.00%> (+0.17%) |
:arrow_up: |
| ubuntu-24.04-pypy3.10 | 90.24% <100.00%> (+0.17%) |
:arrow_up: |
| windows-2022-3.10 | 90.36% <100.00%> (+0.17%) |
:arrow_up: |
| windows-2022-3.11 | 90.30% <100.00%> (+0.17%) |
:arrow_up: |
| windows-2022-3.12 | 90.51% <100.00%> (+0.17%) |
:arrow_up: |
| windows-2022-3.13 | 90.51% <100.00%> (+0.17%) |
:arrow_up: |
| windows-2022-3.8 | 90.29% <100.00%> (+0.17%) |
:arrow_up: |
| windows-2022-3.9 | 90.29% <100.00%> (+0.17%) |
:arrow_up: |
| windows-2022-pypy3.10 | 90.36% <100.00%> (+0.17%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.