Haseeb Raja

Results 58 comments of Haseeb Raja

> Thanks for the PR! > > > I noticed that some tests related to the tokenizer are failing. Note that these are not related to my updates (CC: @rasbt...

@rasbt I am guessing in `test_tokenizer.py`, `xfail` is for cases where models are `gated`?

> Thanks for the PR. This looks great overall. (I would just undo the formatting changes please.) @rasbt Thanks for checking it out. Sorry for the formatting part, my bad....

> I took care of the style thing 😊 Thanks a lot @rasbt 🙏🏻

@rasbt @Andrei-Aksionov I was wondering. If we have access and can run gated tests locally, then ideally those tests should pass. I got issues with llama3.2 tokenizer tests. Do you...

@rasbt Maybe you can take a look if you have some time. I think the original implementation was done by you (if I am not mistaken).

@rasbt I will fix it within one to two days and create a PR.

@rasbt could you assign this issue to me before I begin?

> > [@rasbt](https://github.com/rasbt) I will fix it within one to two days and create a PR. > > Hello @pytholic , how is it going? Still aiming to fix it?...

@wenbin-hhhhh you can use docker-image [here](https://github.com/tum-vision/tandem/pull/46).