pytest icon indicating copy to clipboard operation
pytest copied to clipboard

RFC: from __future__ import annotations + pyupgrade

Open RonnyPfannschmidt opened this issue 2 years ago • 8 comments

RonnyPfannschmidt avatar May 13 '23 11:05 RonnyPfannschmidt

@nicoddemus this one has a major total anhillating force for the automatic backporting

Any idea how we can work with that (or do we backport this one's)

Once we have a idea on backport I'll fix it up and see it through

RonnyPfannschmidt avatar May 19 '23 13:05 RonnyPfannschmidt

Any idea how we can work with that (or do we backport this one's)

Yeah, it needs either a backport itself or to wait for the release of the next minor being imminent before merging. Depending on the confidence we have it's not going to break the maintenance branch..

Pierre-Sassoulas avatar May 19 '23 13:05 Pierre-Sassoulas

Depending on the confidence we have it's not going to break the maintenance branch..

That's the main point I think. Can we think of cases where backporting this could break downstream users somehow in a patch release?

nicoddemus avatar May 19 '23 13:05 nicoddemus

Let's give it a call out, we might Learn of really interesting (or horrifying) use cases for the annotations

Im going to take a look at fixup /backport fixup soonish

RonnyPfannschmidt avatar May 19 '23 14:05 RonnyPfannschmidt

@nicoddemus @bluetech now that 8x. and 7.4 had some major releases, i'd like to propose porting main and 8.x over to the new syntax, i'll try to get it tried this weekend

RonnyPfannschmidt avatar Jan 04 '24 15:01 RonnyPfannschmidt

this pr as is may be a complete pain to review - i wonder if i ought to split it across some logical/file boundaries

RonnyPfannschmidt avatar Jan 05 '24 11:01 RonnyPfannschmidt

I suggest merging quickly to avoid conflicts.

Agree, I won't have time to review this in a timely manner, but please go ahead. Also I suggest to squash the commits into a single one, as the last two are just fixups.

nicoddemus avatar Jan 05 '24 12:01 nicoddemus

i'll add a few more fixups, then squash and submit for final merge

RonnyPfannschmidt avatar Jan 05 '24 13:01 RonnyPfannschmidt

closing in favor of #12467

RonnyPfannschmidt avatar Jun 17 '24 15:06 RonnyPfannschmidt