pytest icon indicating copy to clipboard operation
pytest copied to clipboard

make PytestReturnNotNoneWarning a RemovedIn8Warning by removing the `…

Open graingert opened this issue 3 years ago • 1 comments

…@final` decorator

graingert avatar Aug 08 '22 09:08 graingert

The @final annotations are really just a way to say "we did not design this class for inheritance, if you inherit from it you're on your own". But it's a very weak thing, if we actually want to subclass some class then we should just remove the @final from it, i.e. I don't think the @sealed placeholder is necessary.

bluetech avatar Aug 13 '22 18:08 bluetech

Other than the existing comments we also need a new changelog entry. 👍

nicoddemus avatar Oct 09 '22 13:10 nicoddemus

Thanks @graingert!

nicoddemus avatar Oct 09 '22 23:10 nicoddemus