pytest-html icon indicating copy to clipboard operation
pytest-html copied to clipboard

Published 20 hours ago • verified publisher icon pytest-dev

SASS/SCSS/CSS linter

Open jkowalleck opened this issue 4 years ago • 2 comments

At the moment i write this issue there is no liter used for StyleSheets.

#385 introduces use of for SASS/SCSS
and also introduces a linter. The linter is arguable -
see https://github.com/pytest-dev/pytest-html/pull/385/files#r531829346
see https://github.com/pytest-dev/pytest-html/pull/385#discussion_r531829346

This issue is a reminder, to come back to the topic of a StyleSheets linter.

  • The linter must validate source styles (css/sass/scss)
  • The linter should validate generated styles

candidates

  • https://github.com/elidupuis/mirrors-sass-lint
  • https://github.com/pre-commit/mirrors-scss-lint
  • https://stylelint.io/

see also: https://github.com/pytest-dev/pytest-html/pull/385/files/8873bfb399a063747f19409f730cfb94cc944bd8#diff-63a9c44a44acf85fea213a857769990937107cf072831e1a26808cfde9d096b9

jkowalleck avatar Nov 30 '20 17:11 jkowalleck

Thanks for opening this @jkowalleck. Can you update the links in the issue description? They seem broken

gnikonorov avatar Dec 01 '20 05:12 gnikonorov

reopened conversation https://github.com/pytest-dev/pytest-html/pull/385/files#r531829346 so the link taret is not collapsed by default, to have it not look "broken"

jkowalleck avatar Dec 01 '20 22:12 jkowalleck