pytest-django icon indicating copy to clipboard operation
pytest-django copied to clipboard

tests: run Test_django_db_blocker in testdir

Open blueyed opened this issue 5 years ago • 5 comments
trafficstars

Ref: https://github.com/pytest-dev/pytest-django/pull/802#discussion_r368134433

blueyed avatar Jan 18 '20 14:01 blueyed

@SalmonMode thanks! Do you want to create a PR for this (in case you have it ready already locally)? Otherwise I'll do so later.

I think this PR/change still makes sense (separately), since it simulates running the tests alone. And it could be extended then to test what your renaming/re-arranging would fix (in a separate test).

blueyed avatar Jan 18 '20 14:01 blueyed

I'd be happy to :grin:

There's some already existing tests I can make tweaked copies of to cover this.

Sorry for causing all the ruckus, btw.

SalmonMode avatar Jan 18 '20 14:01 SalmonMode

I'd be happy to

Great. I assume this can be done on top of this one? I.e. run pytest also with selecting only a single test (not using the db) from it.

There's some already existing tests I can make tweaked copies of to cover this.

I'd rather avoid new tests if existing ones can be extended / hardened - the test suite is rather slow already, especially due to all the runpytest_subprocess tests.

Sorry for causing all the ruckus, btw.

No worries.. :)

blueyed avatar Jan 18 '20 15:01 blueyed

I'd rather avoid new tests if existing ones can be extended / hardened - the test suite is rather slow already, especially due to all the runpytest_subprocess tests.

Not a problem. I can just tweak them in place.

I assume this can be done on top of this one? I.e. run pytest also with selecting only a single test (not using the db) from it.

Sorry, I'm not sure I follow. You mean if I can make changes on top of the current change you're making here?

SalmonMode avatar Jan 18 '20 16:01 SalmonMode

Here's the PR https://github.com/pytest-dev/pytest-django/pull/807

SalmonMode avatar Jan 18 '20 16:01 SalmonMode