pytest-cov icon indicating copy to clipboard operation
pytest-cov copied to clipboard

Add .git-blame-ignore-revs

Open akx opened this issue 1 year ago • 7 comments

This makes GitHub (and other tools that support this file, or any Git client with git config blame.ignoreRevsFile .git-blame-ignore-revs set) ignore the large reformatting/automatic commits, to make blame inspection easier.

akx avatar Apr 04 '24 11:04 akx

@Pierre-Sassoulas Added the file to MANIFEST.in too to make the check Tox step pass.

akx avatar May 27 '24 16:05 akx

I'd argue it's not just a formatting change but a functional one. F-strings are more performant so it's more of an enhancement rather than formatting. Usually only patches that are solely formatting are ignored. Bits that are useful for git paleontology aren't supposed to be hidden...

webknjaz avatar Aug 26 '24 09:08 webknjaz

I'm not sure what's the point of .git-blame-ignore-revs in Manifest.in

Without it there, check-manifest would fail.

akx avatar Aug 26 '24 12:08 akx

What is check-manifest and why does it fail ? manifest.in is linked to python packaging and does not involve git, right ?

Pierre-Sassoulas avatar Aug 26 '24 12:08 Pierre-Sassoulas

check-manifest is used to make sure the sdist contains all the source files and nothing is missing. Maybe this new file needs to be an exclude in there.

But alas, I am not sure who is this file for. I will not use it - I prefer to see everything in the gitblame, and jumping back a commit is pretty easy enough (it's just one button in github anyway). image

ionelmc avatar Aug 26 '24 13:08 ionelmc