pytest-cov icon indicating copy to clipboard operation
pytest-cov copied to clipboard

Remove forced config file default of .coveragerc

Open ofek opened this issue 4 years ago • 12 comments

There has been support for pyproject.toml ever since 5.0 https://github.com/nedbat/coveragepy/issues/664#issuecomment-552516277 and based on https://coverage.readthedocs.io/en/6.2/config.html it will automatically find the right file (logic here: https://github.com/nedbat/coveragepy/blob/6.2/coverage/config.py#L493-L519)

I tested this locally and now config can properly be read from the other fallback files

ofek avatar Dec 03 '21 04:12 ofek

@ionelmc @graingert Hello! When you get a moment can you please take a look at this? I can't figure out why the failures are occurring.

ofek avatar Dec 12 '21 22:12 ofek

Ooof sorry for delay, CI approved now. At first glance it seem fine. Please also update AUTHORS/CHANGELOG.rst

ionelmc avatar Dec 21 '21 17:12 ionelmc

Done! I don't know how to fix the tests though.

ofek avatar Dec 21 '21 17:12 ofek

Can I please get help with this?

ofek avatar Mar 30 '22 02:03 ofek

Hello, sorry for tardy response - can you rebase on the master? The CI was cleaned up.

ionelmc avatar Jul 22 '22 09:07 ionelmc

Done!

ofek avatar Jul 22 '22 13:07 ofek

I'm not sure how to fix

ofek avatar Jul 23 '22 05:07 ofek

I still can't figure it out

ofek avatar Aug 24 '22 01:08 ofek

Can you please help?

ofek avatar Nov 27 '22 19:11 ofek

@ofek this looks old and needs conflict resolution. Try rebasing once more?

webknjaz avatar Mar 18 '24 13:03 webknjaz

CI was failing and I don't think the maintainer has time for this unfortunately so there's no point. If you really want me to I will but I feel like it's a waste of time.

ofek avatar Mar 18 '24 15:03 ofek

Sorry, I know this feels bad, having to rebase over and over. But I did point in code commends at the potential cause of the regressions. In hindsight I should have asked you to describe more clearly what this PR is supposed to do and help figure out a good solution instead of reviewing a solution that I am not sure what is supposed to fix. Maybe that would had gotten things moving faster.

Can we restart this? Is there a problem with pytest-cov loading the coverage configuration from a pyproject.toml?

ionelmc avatar Mar 19 '24 00:03 ionelmc