pytest-bdd
pytest-bdd copied to clipboard
Allow Examples table to include values not used in steps
See https://github.com/pytest-dev/pytest-bdd/issues/390 for a description of the error to which this is a fix.
Codecov Report
Merging #391 (422dae6) into master (583910d) will increase coverage by
0.44%. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #391 +/- ##
==========================================
+ Coverage 95.51% 95.95% +0.44%
==========================================
Files 50 50
Lines 1649 1656 +7
Branches 149 149
==========================================
+ Hits 1575 1589 +14
+ Misses 45 41 -4
+ Partials 29 26 -3
| Impacted Files | Coverage Δ | |
|---|---|---|
| pytest_bdd/parser.py | 99.54% <100.00%> (ø) |
|
| tests/feature/test_outline.py | 100.00% <100.00%> (ø) |
|
| tests/feature/test_tags.py | 100.00% <0.00%> (+3.84%) |
:arrow_up: |
| tests/conftest.py | 100.00% <0.00%> (+22.22%) |
:arrow_up: |
| tests/utils.py | 100.00% <0.00%> (+33.33%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 583910d...422dae6. Read the comment docs.
@youtux, it seems that you were the last person to touch this code. Would you be able to review this PR, or else how do I request a review given that I don't have write access to the repo?
@hicksjduk Could you please rename the pull request to something like "Allow store values in Examples not used in steps" to show the real value of this feature
@youtux Please review
Done.
Cucumber (gherkin lint) uses no-unused-variables rule to optionally raise on this. @youtux Do you think we need to make it an option?
Isn't this a rule in the linter that checks the implementation code? Not in the functionality that implements the gherkin bindings. I can't find any reference in the cucumber documentation to this rule.
@hicksjduk Oleg means https://www.npmjs.com/package/gherkin-lint @olegpidsadnyi @hicksjduk please check #439 . User could explicitly decide to use this feature using new parameters in "scenario" and "scenarios". It also supersede this PR
I think we should just allow examples to include values that are not used. I wouldn't make it an option, I find it unnecessary complication.
@olegpidsadnyi please review