pytest-asyncio icon indicating copy to clipboard operation
pytest-asyncio copied to clipboard

Test for, and suppress, additional get_event_loop() DeprecationWarnings

Open SyntaxColoring opened this issue 10 months ago • 2 comments

This attempts to do what's described in https://github.com/pytest-dev/pytest-asyncio/issues/757#issuecomment-1985912818, to solve continued instances of issue #757:

  • ~~Add tests to catch any lingering asyncio.get_event_loop() DeprecationWarnings.~~
    • ~~The existing tests are already catching a bunch, but only when they're run under specific Python patch versions. So the test part of this PR just configures tox and GitHub Actions to do that.~~
    • I could only reproduce the warnings on specific Python 3.10.x patch versions, and I couldn't easily get CI to use those versions, so we don't have tests for this.
  • Suppress those warnings.

SyntaxColoring avatar Apr 18 '24 04:04 SyntaxColoring

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.59%. Comparing base (dfe6e7c) to head (8f9388f). Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #817   +/-   ##
=======================================
  Coverage   95.59%   95.59%           
=======================================
  Files           2        2           
  Lines         477      477           
  Branches       96       95    -1     
=======================================
  Hits          456      456           
  Misses         12       12           
  Partials        9        9           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 18 '24 05:04 codecov-commenter

@seifertm Ping—do the latest changes address your feedback?

SyntaxColoring avatar May 09 '24 13:05 SyntaxColoring