TopoNetX icon indicating copy to clipboard operation
TopoNetX copied to clipboard

Testing solution for issue #195

Open devendragovil opened this issue 2 years ago • 5 comments

Trying a way to resolve the datasets issue #195. Will need to raise a PR for this to test out the solution

devendragovil avatar Sep 12 '23 09:09 devendragovil

Codecov Report

Patch coverage has no change and project coverage change: +0.69% :tada:

Comparison is base (5570330) 85.56% compared to head (2b00eb1) 86.25%. Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
+ Coverage   85.56%   86.25%   +0.69%     
==========================================
  Files          23       23              
  Lines        2848     3377     +529     
==========================================
+ Hits         2437     2913     +476     
- Misses        411      464      +53     

see 9 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 12 '23 09:09 codecov[bot]

I am not experienced with setuptools and thus cannot comment on the right approach here. Removing me as reviewer here :)

ffl096 avatar Sep 13 '23 06:09 ffl096

@mhajij This PR is not ready yet.

I initially raised this PR so as to be able to test my solutions. Converting this to draft for now.

devendragovil avatar Sep 13 '23 19:09 devendragovil

@mhajij did you mean to close this?

ffl096 avatar Sep 22 '23 14:09 ffl096

@mhajij did you mean to close this?

@ffl096, I reopened it.

mhajij avatar Sep 22 '23 15:09 mhajij

setuptools-scm has been added to the build process with #381.

ffl096 avatar Aug 01 '24 09:08 ffl096