TopoModelX icon indicating copy to clipboard operation
TopoModelX copied to clipboard

Clarification on `scatter` utilities

Open ffl096 opened this issue 10 months ago • 0 comments

TopoModelX contains some scatter functions in utils.scatter, that -- according to the module docstring -- are adapted from torch_scatter. Is there a specific reason why we ship our own implementation? torch_scatter is a dependency already.

If yes, we should document that reason and how the build-in implementation differs from torch_scatter (which, for me, is not at all obvious from looking at the code). Otherwise remove it and use the existing implementation in torch_scatter everywhere.

ffl096 avatar Sep 15 '23 13:09 ffl096