TopoModelX
TopoModelX copied to clipboard
Problem with test_reset_parameters() in test_hsn_layer.py
Hi!
In test_reset_parameters()
https://github.com/pyt-team/TopoModelX/blob/ed4bd966a2cb3969466f60aabd74fa7a08247ba8/test/nn/simplicial/test_hsn_layer.py#L34, the HSNLayer
modules are checked to be instances of torch.nn.Conv2d
. However, none of them are, since the layer consists of only Aggregation
(from topomodelx.base.aggregation
) and Conv
from (topomodelx.base.conv
).
Thus, the test will be passed without actually checking the parameter reset.
(The test itself is incorrect: after resetting, the parameters of a torch.nn.Conv2d
layer are compared to zeros https://github.com/pyt-team/TopoModelX/blob/ed4bd966a2cb3969466f60aabd74fa7a08247ba8/test/nn/simplicial/test_hsn_layer.py#L36, which is not how they are initialized.)