ytfzf icon indicating copy to clipboard operation
ytfzf copied to clipboard

[BUG]: Minor output bug after selecting video

Open guiltiest-gear opened this issue 1 year ago • 3 comments

Describe the bug

After selecting a video to play, a blank line and the literal characters of ${new_line} show up in the output

To Reproduce

  1. Install ytfzf 2.6.1
  2. Enable thumbnails in config or with command line option
  3. Search for a video
  4. Notice how there is a blank like after the scraping message, and the string of ${new_line} appended to Fetching thumbnails...

Expected behavior

There should be no blank like and no extra characters

Screenshots

Screenshot_2023-09-17_18-47-21

Information

  • OS: EndeavourOS
  • Terminal: kitty 0.29.2
  • Ytfzf version: 2.6.1
  • Output of readlink $(which sh): bash
  • (if is a thumbnail issue) run ytfzf --thumbnail-log=log.txt and post the file:

Additional context

This bug doesn't occur in 2.6.0, so it must be from a commit between 2.6.0 and 2.6.1

guiltiest-gear avatar Sep 18 '23 02:09 guiltiest-gear

I believe this is fixed in the development branch, you could try using that.

Euro20179 avatar Sep 18 '23 15:09 Euro20179

I'll clone to the latest commit and get back to you on that

guiltiest-gear avatar Sep 18 '23 21:09 guiltiest-gear

Newest commit fixes ${new_line} bug, but extra blank line is still present Screenshot_2023-09-18_14-27-02

guiltiest-gear avatar Sep 18 '23 21:09 guiltiest-gear