ani-cli icon indicating copy to clipboard operation
ani-cli copied to clipboard

feat: allow -c to continue from dub

Open ykhan21 opened this issue 1 year ago • 0 comments

Pull Request Template

Type of change

  • [ ] Bug fix
  • [x] Feature
  • [ ] Documentation update

Description

This is a POC for #1371. It adds a sub/dub column in the history file so -c knows whether to continue subbed or dubbed. It is not thoroughly tested. It should work with old history files (without the sub/dub column). The current behavior (in this PR) is so that if you switch between subbed and dubbed, the history file should reflect the latest switch. If we want to track subbed and dubbed separately, a change can be added to allow for that.

Checklist

  • [x] any anime playing
  • [x] bumped version

  • [x] next, prev and replay work
  • [x] -c history and continue work
  • [ ] -d downloads work
  • [ ] -s syncplay works
  • [ ] -q quality works
  • [ ] -v vlc works
  • [ ] -e select episode works
  • [ ] -S select index works
  • [ ] -r range selection works
  • [ ] --skip ani-skip works
  • [ ] --skip-title ani-skip title argument works
  • [ ] --no-detach no detach works
  • [ ] --dub and regular (sub) mode both work
  • [ ] all providers return links (not necessarily on a single anime, use debug mode to confirm)

  • [ ] -h help info is up to date
  • [ ] Readme is up to date
  • [ ] Man page is up to date

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)

ykhan21 avatar Jun 14 '24 23:06 ykhan21