ani-cli icon indicating copy to clipboard operation
ani-cli copied to clipboard

fix: no-detach detatching

Open port19x opened this issue 1 year ago • 6 comments

https://github.com/pystardust/ani-cli/pull/1264#issuecomment-1925810856

port19x avatar Feb 04 '24 20:02 port19x

I think shellcheck is a little confused here

port19x avatar Feb 04 '24 20:02 port19x

Just tested out this MR and it does not seem to work. I feel like not redirecting the mpv output to /dev/null is necessary since when used with the kitty protocol the frames are sent through a bytestream from mpv to the terminal.

germaniuss avatar Feb 08 '24 16:02 germaniuss

Just tested out this MR and it does not seem to work. I feel like not redirecting the mpv output to /dev/null is necessary since when used with the kitty protocol the frames are sent through a bytestream from mpv to the terminal.

By not work, I mean that the video is not showing. I no longer need to pkill the mpv process since it does not detach anymore, but the kitty protocol messages are not redirected to the terminal.

germaniuss avatar Feb 08 '24 16:02 germaniuss

fixed, please try again to verify

port19x avatar Feb 08 '24 16:02 port19x

Well that was fast haha, it does work now!!

germaniuss avatar Feb 08 '24 16:02 germaniuss

On vacation doing some random coding currently :D

port19x avatar Feb 08 '24 16:02 port19x

oh wait, it did

Derisis13 avatar Mar 22 '24 00:03 Derisis13

Yeah, I wanted to be smart, but shellcheck didn't let me

port19x avatar Mar 22 '24 06:03 port19x