tobler icon indicating copy to clipboard operation
tobler copied to clipboard

Site docs return 404

Open JosiahParry opened this issue 1 year ago • 6 comments

The 3 vignettes at pysal.org/tobler presently return a 404 with nbviewer.

For example: https://nbviewer.org/github/pysal/tobler/blob/master/notebooks/census_to_hexgrid.ipynb

JosiahParry avatar Feb 16 '24 03:02 JosiahParry

hm, looks like thats cause they're still pointing at master instead of main (swap and it works fine)

im not actually sure where thats happening cause that notebook is sitting in the docs dir where it should be. Will take a look, thanks for raising

knaaptime avatar Feb 16 '24 03:02 knaaptime

@jGaboardi do you remember where those are set?

knaaptime avatar Feb 16 '24 03:02 knaaptime

https://nbviewer.org/github/pysal/tobler/blob/master/notebooks/census_to_hexgrid.ipynb

Where is that above link coming from? Are you simply launching nbviewer manually or do we have that link embedded somewhere in the repo/docs site?

jGaboardi avatar Feb 16 '24 14:02 jGaboardi

Looks like those nbviewer links are hardcoded directly in the index.rst (lines ~13, 21, 29, so just a link update?).

For the docs tutorial page, tutorial.rst is pointing to the notebooks in docs/notebooks (e.g., 01_interpolation_methods_overview.ipynb). I ran into this recently in a different project where I didn't want to maintain two copies. sphinx may not like ../ and I found nbsphinx_link worked for me if you're open to the added docs requirement.

jbousquin avatar Feb 16 '24 14:02 jbousquin

Looks like those nbviewer links are hardcoded directly in the index.rst (lines ~13, 21, 29, so just a link update?).

Yep, this looks to be the case!

jGaboardi avatar Feb 16 '24 15:02 jGaboardi

Sweet, thanks @jbousquin! Nbsphinx_link looks great

knaaptime avatar Feb 16 '24 15:02 knaaptime