spreg icon indicating copy to clipboard operation
spreg copied to clipboard

lint repo with `ruff` -- `pre-commit`

Open jGaboardi opened this issue 1 year ago • 4 comments

ensure spreg is actually being linted with ruff via .pre-commit

jGaboardi avatar Sep 01 '24 17:09 jGaboardi

Preliminary lint check found 1361 errors. I will likely be tackling the linting across multiple PRs.

jGaboardi avatar Sep 01 '24 17:09 jGaboardi

@pedrovma Considering https://github.com/pysal/spreg/pull/156#issuecomment-2325161757:

  1. Is this something you are interested in?
  2. If yes, would it help for me to put in 1 PR per file to ease the merging into the private branch?

In my opinion, this is something that spreg desperately needs to ensure maintainability into the future[^1][^2]

[^1]: currently 1533 warnings in dev [^2]: currently 1361 items that need attention for linting

jGaboardi avatar Sep 03 '24 20:09 jGaboardi

Hi @jGaboardi . I think individual PRs would be too much work. Luc and I are just finishing some tests and formatting for the release of version 1.7. It will be released by the end of this month. After the release, we can freeze the development in the private repo so you can work freely on the linting here. What do you think?

Many thanks.

pedrovma avatar Sep 04 '24 12:09 pedrovma

Sure. That works.

jGaboardi avatar Sep 04 '24 12:09 jGaboardi