input is not sanitised before it is used

[ljwolf]

I'm not running checks on the input, nor casting input to an array in the Spanning_Tree clusterer.

[jGaboardi]

@ljwolf Any update on this?

[ljwolf]

Nope. A simple "asarray" would do it I think.

[jGaboardi]

@ljwolf Is this from within skater.Skater()? I can't find anything defined as Spanning_Tree within spopt. If it is, doesn't the .values property automatically convert to a numpy.array in data?:

def solve(self):
    data = self.gdf
    X = data[self.attrs_name].values
    model = SpanningForest(**self.spanning_forest_kwds)
    model.fit(
        self.n_clusters,
        self.w,
        data=X,
        quorum=self.floor,
        trace=self.trace,
        islands=self.islands,
    )

[jGaboardi]

@sjsrey Any thoughts here? This seems like it would be an easy issue to close out, but I'm not sure where it was happening before.

[ljwolf]

Using the .values is fine! I think I filed this before the new api

[jGaboardi]

OK, awesome. Thanks for the feedback @ljwolf! I'll go ahead and close this then. Also, happy holidays!