spopt icon indicating copy to clipboard operation
spopt copied to clipboard

LSCP Notebook Plots

Open erinrolson opened this issue 3 years ago • 2 comments

spopt -> notebooks -> lscp.ipynb cells 19, 20, 21 plot_results(lscp_from_cost_matrix, facility_points) should be plot_results(lscp_from_cost_matrix, facilities_snapped) ?

I'm happy to make the amendments and add to my pull request if you agree.

erinrolson avatar Jul 26 '22 18:07 erinrolson

Hey! I think @gegen07 set this up in all the notebooks to plot the original observation points see cells 22- in the MCLP notebook. I think there could be an argument made for adding a plot demonstrating the snapped locations, but we should not remove the plot demonstrating the "true" locations.

@gegen07, what are your thoughts on this?

jGaboardi avatar Jul 26 '22 20:07 jGaboardi

Yeah, just to plot the original observation points. Although the from_geodataframe uses the snapped points in the model, I thought to use snap operation only to take the distance between clients and facilities.

I think we can add a plot to show the snapped locations and add a description of the "real" plot to state the differences. Subplots maybe would be a great idea in this case.

gegen07 avatar Jul 26 '22 22:07 gegen07

We give a plot on the location + explanations, so that should be enough (xref #288)

jGaboardi avatar Oct 23 '22 05:10 jGaboardi