splot
splot copied to clipboard
DOC: comments to examples
Hi, few comments to examples as a part of openjournals/joss-reviews#1882.
All of them are nice and detailed, covering a lot of options splot offers, so I have just a couple minor remarks. None of them are critical for the review, but they might help.
-
It is unclear where to find them. There are three examples on the homepage of docs, but 5 in the notebooks folder of the repo. Nowhere in the docs is the link to the rest. Documentation nor readme do not indicate that there are any other resources to check.
-
Space-time visualisations (giddy) is missing a description. There are just a minor comments in the code. It would be good to explain what is going on, why and how to interpret resulting plots.
-
In
mapping_vba, I assume you wanted to dofrom splot.mapping import shift_colormapinstead iffrom splot._viz_utils import shift_colormapas_viz_utilsis private. -
There are some typos here and there across notebooks.
In
mapping_vba, I assume you wanted to do fromsplot.mapping import shift_colormapinstead if fromsplot._viz_utils import shift_colormapas_viz_utilsis private.
This will still need updating/adjusting part of https://github.com/pysal/mapclassify/issues/272