splot icon indicating copy to clipboard operation
splot copied to clipboard

DOC: comments to examples

Open martinfleis opened this issue 6 years ago • 1 comments

Hi, few comments to examples as a part of openjournals/joss-reviews#1882.

All of them are nice and detailed, covering a lot of options splot offers, so I have just a couple minor remarks. None of them are critical for the review, but they might help.

  1. It is unclear where to find them. There are three examples on the homepage of docs, but 5 in the notebooks folder of the repo. Nowhere in the docs is the link to the rest. Documentation nor readme do not indicate that there are any other resources to check.

  2. Space-time visualisations (giddy) is missing a description. There are just a minor comments in the code. It would be good to explain what is going on, why and how to interpret resulting plots.

  3. In mapping_vba, I assume you wanted to do from splot.mapping import shift_colormap instead if from splot._viz_utils import shift_colormap as _viz_utils is private.

  4. There are some typos here and there across notebooks.

martinfleis avatar Nov 17 '19 15:11 martinfleis

In mapping_vba, I assume you wanted to do from splot.mapping import shift_colormap instead if from splot._viz_utils import shift_colormap as _viz_utils is private.

This will still need updating/adjusting part of https://github.com/pysal/mapclassify/issues/272

jGaboardi avatar Jun 19 '25 00:06 jGaboardi