momepy
momepy copied to clipboard
Functional blockcount
Functional blockcount using groupby.
Potentially, it could be reimplemented with two calls to describe_reached:
- one with to aggregate the values on the neighbours graph 2.one to aggregate the areas then return 1 / 2
Or it could be left to the user.
Codecov Report
Attention: Patch coverage is 96.63866% with 4 lines in your changes missing coverage. Please review.
Project coverage is 97.9%. Comparing base (
4037c70) to head (74494f0). Report is 84 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| momepy/functional/_diversity.py | 91.5% | 4 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #584 +/- ##
=======================================
+ Coverage 97.4% 97.9% +0.6%
=======================================
Files 26 37 +11
Lines 4328 5869 +1541
=======================================
+ Hits 4214 5747 +1533
- Misses 114 122 +8
| Files with missing lines | Coverage Δ | |
|---|---|---|
| momepy/functional/tests/test_diversity.py | 100.0% <100.0%> (ø) |
|
| momepy/functional/tests/test_intensity.py | 100.0% <100.0%> (ø) |
|
| momepy/intensity.py | 99.5% <100.0%> (+<0.1%) |
:arrow_up: |
| momepy/tests/test_intensity.py | 100.0% <100.0%> (ø) |
|
| momepy/functional/_diversity.py | 96.4% <91.5%> (ø) |
This will be superseded by libpysal.Graph.describe, correct?
yes, i need to add the decorator and fix some of the failing tests though.
Anything blocking this merge?
@jGaboardi I was just waiting for CI to finish :)