mgwr icon indicating copy to clipboard operation
mgwr copied to clipboard

Undefined local variable used in search.py: golden_section (Line 46, 47)

Open xyluo25 opened this issue 1 year ago • 2 comments

Hi Developers,

please check the error exist in search.py in line 46 and 47. image

Do we need to add n as a parameter in function golden_section or we will remove n in the function?

xyluo25 avatar Feb 13 '24 19:02 xyluo25

@xyluo25 Instead of posting screenshots of code, you can include the permalink to the exact location by clicking next to the line number for a pop-up dialogue box like so:

Screenshot 2024-02-13 at 7 41 20 PM

Then you can easily embed the permalink here with markdown syntax like: [some text](url). For example: "The relevant lines in the golden_section() function are here". Or you can simply paste the permalink in here and get a nice rendering of the code with a functional hyperlink:

https://github.com/pysal/mgwr/blob/423726a3a949147fd5416bef0fec33021a51cbf3/mgwr/search.py#L46-L47

jGaboardi avatar Feb 14 '24 00:02 jGaboardi

Hello @jGaboardi, thank you for sharing this information. I've learned so much from you. I plan to implement it later.

xyluo25 avatar Feb 14 '24 18:02 xyluo25