mapclassify icon indicating copy to clipboard operation
mapclassify copied to clipboard

Add VBA functionality

Open sjsrey opened this issue 6 years ago • 4 comments

Following the suggestions raised in #36 by @slumnitz.

sjsrey avatar Jun 26 '19 18:06 sjsrey

How would this work exactly? Just opening the discussion.

My main concern is in making intuitive the classification of the vba variable given the classification of the main variable is obvious since this will be a method of a given classifier. For example given a continuous variable y:

classi = Quantiles (y)
classi.plot(geoms)

This would be a standard choropleth. Now, if I have another variable (e.g. confidence) that I want to use to modulate alpha values. How should this be passed in? More importantly, how should we allow the user to determine the classiffication scheme for that? A couple of ideas (totally brainstorming so might not make sense):

  1. We use the style of choropleth_vba and allow the user to pass any classifier. This is consistent but a bit awkward in a way since they would pick the classifier for y in one way and for confidence in another)
  2. We don't allow the user to pass classifiers for vba and use the same classifier and same parameters for confidence as used for y. This is consistent within the method and simpler to set up but arguably a bit too restrictive.
  3. Something in the middle?

darribas avatar Jun 26 '19 19:06 darribas

Another possibility:

class_a = Quantiles(a)
class_b = Quantiles(b)
vba.plot(class_a, class_b, geoms)

where vba is an instance of a new class.

I think loading up the plot method in the univariate classifiers is going to complicated things.

sjsrey avatar Jun 26 '19 23:06 sjsrey

I really like that approach. I'd maybe call it choropleth instead of vba?

darribas avatar Jun 27 '19 07:06 darribas

splot.vba_chorpleth actually does exactly this under the hood. For maintaining purposes we might want to consider to leverage functionality for both and just store it at one place.

slumnitz avatar Jun 27 '19 17:06 slumnitz

Can this be closed since the plotting is in splot?

martinfleis avatar Jan 12 '23 19:01 martinfleis

I think so. We can reopen if needed.

jGaboardi avatar Jan 13 '23 01:01 jGaboardi