libpysal icon indicating copy to clipboard operation
libpysal copied to clipboard

Migration guide W->Graph

Open sjsrey opened this issue 1 year ago • 6 comments

Two teaching materials where one is derived from the other and updated to use Graph instead of W.

  • Dani's W - https://darribas.org/gds_course/content/bE/lab_E.html
  • Martin's Graph https://martinfleischmann.net/sds/chapter_04/hands_on.html

Apart from the different datasets, it is nearly 1:1 and can be used as a basis of the migration guide.

edited by @martinfleis

sjsrey avatar May 28 '24 10:05 sjsrey

following the discussion from the June dev meeting, we want to open a discussion about Graph nomenclature (specifically when you need to work with multiple graphs simultaneously e.g. from libpysal and networkx at once) it might be easier to rename Graph to GeoGraph or similar. Opening here for discussion so we can vote in the next dev meeting

knaaptime avatar Jun 06 '24 16:06 knaaptime

I am tentatively for the renaming as it is going to be clearer to the user what is required where and avoids some confusion between different graph representations. But I also don't feel super strongly about this. It's also going to break some of my research code and teaching materials but I can deal with that easily.

martinfleis avatar Jun 06 '24 16:06 martinfleis

xref: https://github.com/pysal/momepy/issues/579

I have no strong opinions either way, so probably not a bad to go with the more distinctive GeoGraph. Wasn't GeoGraph the original name that was under consideration when the refactor first started out?

jGaboardi avatar Jun 07 '24 03:06 jGaboardi

Existence of this https://geograph.readthedocs.io/en/latest/ may affect the decision here...

martinfleis avatar Jun 19 '24 13:06 martinfleis

Are there any other alternative names being thrown around?

jGaboardi avatar Jun 19 '24 13:06 jGaboardi

at the steering committee meeting this morning we voted to keep Graph for the time being

knaaptime avatar Jun 19 '24 16:06 knaaptime

complete via #733

jGaboardi avatar Jul 21 '24 15:07 jGaboardi