libpysal icon indicating copy to clipboard operation
libpysal copied to clipboard

migrate away from star import for explicit ones

Open jGaboardi opened this issue 2 years ago • 2 comments

xref: https://github.com/pysal/libpysal/pull/597#discussion_r1368292698

Migrate away from star import for explicit ones. Once complete we can remove "F403", # star import; unable to detect undefined names in pyproject.toml.

jGaboardi avatar Oct 23 '23 13:10 jGaboardi

Ideally, instead of from .alpha_shapes import * we should do import alpha_shapes and then use alpha_shapes.function in the code. That way we minimise ambiguity of what comes from where.

In __init__.py, we could potentially leave stars but I bet there are other, better solutions than that.

martinfleis avatar Oct 23 '23 14:10 martinfleis

Agreed.

jGaboardi avatar Oct 23 '23 14:10 jGaboardi