libpysal icon indicating copy to clipboard operation
libpysal copied to clipboard
verified publisher icon pysal

[WIP] remove Ids attribute

Open sjsrey opened this issue 5 years ago • 1 comments

This is addressing #284 and would remove the ids attribute.

Remaining to be done:

  • [ ] 3 locally failing tests in test_contiguity.py
  • [ ] testing downstream

sjsrey avatar Jun 29 '20 04:06 sjsrey

The remaining tests that are failing involve the idVariable.

In exploring those tests, I think they are covering behaviour that is not longer supported when ids are removed. At the same time, we might also want to remove idVariable support as it was the combination of ids and idVariable that has caused a lot of complications.

sjsrey avatar Jun 29 '20 17:06 sjsrey