libpysal icon indicating copy to clipboard operation
libpysal copied to clipboard

Ids option is ignored by W.__init__

Open ljwolf opened this issue 5 years ago • 1 comments

You can send whatever you like to W(neighbors, ids='garbage'), because it's never used. This is the genesis of many bugs in the past & present.

W({1:[2,3], 2:[3], 3:[2]}, ids="If you're reading this, something's up!")

It looks like it's never actually been plugged in anywhere. Back in 3ef349, it was added, but never used anywhere afaict?

This really needs to be cleaned up once and for all, I think.

ljwolf avatar Apr 29 '20 15:04 ljwolf

Will ids become a property/attribute of W object in future? I've not seen many snippets where it's used

NVM looks like its solved already :)

MgeeeeK avatar Jun 29 '20 02:06 MgeeeeK