Pengram

[sjsrey]

A pengram combines Pen's Parade and a choropleth map.

Functionality

• ascending/descending Pen's Parades
• weighted Pen's Parades
• query functionality for pengram

This is a work in progress for discussion and feedback.

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 89.89899% with 10 lines in your changes missing coverage. Please review.

Project coverage is 96.3%. Comparing base (a2fe5ee) to head (77ac3e8). Report is 37 commits behind head on main.

Files	Patch %	Lines
inequality/pen.py	89.9%	10 Missing :warning:

Additional details and impacted files

@@           Coverage Diff           @@
##            main     #72     +/-   ##
=======================================
- Coverage   98.2%   96.3%   -1.9%     
=======================================
  Files          4       5      +1     
  Lines        334     433     +99     
=======================================
+ Hits         328     417     +89     
- Misses         6      16     +10     

Files	Coverage Δ
inequality/pen.py	89.9% <89.9%> (ø)

[jGaboardi]

My initial comment is that this is really cool 🎆

[martinfleis]

out of curiosity whats the aversion to seaborn? it's already a dependency in the metapackage because of segregation, and its own footprint is minimal

@knaaptime it is not an aversion to seaborn. That just happened to be a victim of a general rule of trying to avoid additional dependencies to minimise long-term maintenance burden. Stuff can and will break and less stuff we depend on, less issues we will have to solve. I'm likely too conservative in this but I believe that an additional dependency shall be added if we either can't work without it or if working without it would be unnecessarily complicated. I don't think that a single barplot call saving maybe a one line of matplotlib code here is just not enough. It is a similar case we had in mapclassify. In the end, there was no reason for an additional dependency.