access icon indicating copy to clipboard operation
access copied to clipboard

Change max cost to include threshold

Open JamesSaxon opened this issue 3 years ago • 3 comments

This is a change was requested by @knaaptime in the discussion for 26. It is a one-character fix here:

https://github.com/pysal/access/blob/bfae8edbbcb304e67884a3b1cbf292cc410fa380/access/fca.py#L55

But it will also break the expectations of the zero-catchment tests here:

https://github.com/pysal/access/blob/bfae8edbbcb304e67884a3b1cbf292cc410fa380/access/tests/test_floating_catchment_area.py#L75-L80

Not a hard change but your judgment call.

JamesSaxon avatar Apr 03 '22 21:04 JamesSaxon

Hey @knaaptime, just following up here. Happy to update the code and tests, but wanted one last confirmation on your side...

JamesSaxon avatar May 14 '22 18:05 JamesSaxon

@JamesSaxon Do we want to wait for Eli's response before doing this next release?

jGaboardi avatar May 14 '22 20:05 jGaboardi

@jGaboardi, unless it's a ton of work for you, I'd rather just get that piece out.

JamesSaxon avatar May 14 '22 21:05 JamesSaxon