index name hardcoded to 'geoid'

Open knaaptime opened this issue 3 years ago • 2 comments

this isn't strictly a problem, but we might want to avoid naming the index explicitly to 'geoid', which usually means FIPS code. If folks arent using census data, but they get back a dataframe indexed on 'geoid' it might cause some confusion

Jan 31 '22 20:01 knaaptime

@knaaptime Here are you referring to demand_index and supply_index, or something else?

https://github.com/pysal/access/blob/38773362dcafb8041eab4a6826fb620f6f26db40/access/fca.py#L86-L88

Or has this been addressed in the intermediary?

Jul 04 '25 16:07 jGaboardi

Actually I did find 2 examples:

https://github.com/pysal/access/blob/38773362dcafb8041eab4a6826fb620f6f26db40/access/fca.py#L311

https://github.com/pysal/access/blob/38773362dcafb8041eab4a6826fb620f6f26db40/access/fca.py#L437

@JamesSaxon do you recall if these should be replaced with demand_index or supply_index?

Jul 04 '25 21:07 jGaboardi