pyrra icon indicating copy to clipboard operation
pyrra copied to clipboard

unknown field "latencyNative" in dev.pyrra.v1alpha1.ServiceLevelObjective.spec.indicator

Open eslam-gomaa opened this issue 11 months ago • 4 comments

I get CRD validation error when using that example pyrra-connect-latency.yaml

error validating data: ValidationError(ServiceLevelObjective.spec.indicator): unknown field "latencyNative" in dev.pyrra.v1alpha1.ServiceLevelObjective.spec.indicator; if you choose to ignore these errors, turn validation off with --validate=false
apiVersion: pyrra.dev/v1alpha1
kind: ServiceLevelObjective
metadata:
  name: kafka-producing-latency
  namespace: kafka-cluster-1
  labels:
    prometheus: k8s
    role: alert-rules
spec:
  target: '99.999'
  window: 1w
  description: test latency
  indicator:
    latencyNative:
      latency: 1ms
      total:
        metric: kafka_producer_request_latency_avg


And for the other way to create latency based SLO, it doesn't work when the metric has an expression is there a way to pass something like this "kafka_producer_request_latency_avg <= 4" as the success metric ?

apiVersion: pyrra.dev/v1alpha1
kind: ServiceLevelObjective
metadata:
  name: kafka-producing-latency
  namespace: kafka-cluster-1
  labels:
    role: alert-rules
    pyrra.dev/team: my-team
spec:
  # alerting:
  #   disabled: true
  target: "99.99"
  window: 1w
  description: "Kafka latency"
  indicator:
    latency:
      success:
-        metric: kafka_producer_request_latency_avg
+        metric: kafka_producer_request_latency_avg <= 4
      total:
        metric: kafka_producer_request_latency_avg

Pyrra version: v0.6.4 helm chart release: 0.8.0

eslam-gomaa avatar Jul 20 '23 07:07 eslam-gomaa