pyrra icon indicating copy to clipboard operation
pyrra copied to clipboard

Custom PropagationLabelsPrefix

Open prein opened this issue 1 year ago • 2 comments

Any chance PropagationLabelsPrefix can be configurable? We are using / in some of our labels. Prefixing with pyrra.dev/ makes Kubernetes barf. Labels are allowed to contain only one slash.

prein avatar Mar 28 '24 16:03 prein

Can you give some more concrete examples? That'd be helpful. I don't think anything speaks against making it more configurable other than a bit more complexity in the code.

metalmatze avatar Apr 01 '24 17:04 metalmatze

Thanks for reply. Re: example. In my organization we use labels prefixed with company name, such as companyname/owner or companyname/component. Prefixing them with another slash containing prefix gives errors like the following when attempting to create the SLO resource

pyrra.dev/companyname/owner": a qualified name must consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyName', or 'my.name', or '123-abc', regex used for validation is '([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9]') with an optional DNS subdomain prefix and '/' (e.g. '[example.com/MyName](http://example.com/MyName)'),

prein avatar Apr 02 '24 10:04 prein