pyro-api icon indicating copy to clipboard operation
pyro-api copied to clipboard

feat: send alert image with telegram message, if requested

Open blenzi opened this issue 2 years ago • 2 comments

This PR adds the possibility to send the alert image together with a telegram message, if requested

  • add boolean field send_image to recipient table
  • add int field media_id to notification table
  • add and use python-telegram-bot dependency (negligible increase in docker image size)

blenzi avatar Aug 11 '23 18:08 blenzi

Nice of you to open a PR :pray: When you're ready and want to get it reviewed, post a comment in this Pull Request with this message: /quack review

ghost avatar Aug 11 '23 18:08 ghost

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.31%. Comparing base (767be30) to head (ecb101a). Report is 36 commits behind head on main.

Files with missing lines Patch % Lines
src/app/api/endpoints/media.py 33.33% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #279      +/-   ##
==========================================
- Coverage   94.54%   94.31%   -0.23%     
==========================================
  Files          63       66       +3     
  Lines        1594     1690      +96     
==========================================
+ Hits         1507     1594      +87     
- Misses         87       96       +9     
Flag Coverage Δ
client 90.58% <ø> (?)
unittests 94.51% <92.59%> (-0.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 11 '23 18:08 codecov[bot]

Closing as this was for the legacy data model, feel free to reopen if I missed something!

frgfm avatar Jan 09 '25 12:01 frgfm