easy-photography-portfolio icon indicating copy to clipboard operation
easy-photography-portfolio copied to clipboard

Published 20 hours ago • verified publisher icon pyronaur

Categories above albums to improve usability

Open DitgerDW opened this issue 5 years ago • 11 comments

DitgerDW avatar Feb 18 '20 16:02 DitgerDW

The changes have been made, although I'll look into how this can become a on off setting with off as default

DitgerDW avatar Mar 03 '20 11:03 DitgerDW

Can you check and make sure the coding standards match WordPress standards too? https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/

pyronaur avatar Mar 04 '20 12:03 pyronaur

Hey @Ditger - let me know when this is ready for re-review!

pyronaur avatar Mar 05 '20 14:03 pyronaur

It can be re-reviewed, normally it should be okay with the WordPress standards, let me know if there are things that need to be changed or improved.

DitgerDW avatar Mar 05 '20 15:03 DitgerDW

All requested changes have been applied, normally all inconsistencies are resolved, let me know when I forgot one :)

DitgerDW avatar Mar 06 '20 09:03 DitgerDW

Should be resolved now, the else statement was initially for testing, but is indeed not necessary in the final build.

DitgerDW avatar Mar 06 '20 11:03 DitgerDW

Thanks for working on this! I'll give it a spin over the weekend and see how it looks and works.

pyronaur avatar Mar 06 '20 13:03 pyronaur

It was a great experience to work on this, and with the last changes, the foreach is now more consistent like the rest, and also the links are fully operational.

DitgerDW avatar Mar 06 '20 14:03 DitgerDW

Should be fixed now, didn't notice those, thanks for letting me know :)

DitgerDW avatar Mar 07 '20 23:03 DitgerDW

Changes have been applied

DitgerDW avatar Mar 10 '20 14:03 DitgerDW

I checked out the PR to give it a spin. Code-wise this looks good, but I think we need to brainstorm a bit about how it looks on the website.

I took a few screenshots in various themes:

Screen Shot 2020-10-04 at 7 58 09 PM Screen Shot 2020-10-04 at 7 58 22 PM Screen Shot 2020-10-04 at 7 58 36 PM Screen Shot 2020-10-04 at 7 56 26 PM Screen Shot 2020-10-04 at 7 56 09 PM

2 things stand out to me:

  1. There's no indication on which category I currently have open, which might be a bit confusing

  2. In some layouts, the page appears slightly broken. We probably can't make it beautiful in every theme, but I think we can try at least making it passable in most. Perhaps add some spacing?

Not sure what's a good approach here. I tried adding a button class to the elements, and with a little bit of CSS we can center-align them, like so:

Screen Shot 2020-10-04 at 8 09 34 PM

But I'm not sure how that'll work. Any ideas? Let me know if you need help or any questions dealing with the plugins CSS.

pyronaur avatar Oct 04 '20 17:10 pyronaur