obsidian-tracker icon indicating copy to clipboard operation
obsidian-tracker copied to clipboard

Cleanup docs and examples

Open lazyguru opened this issue 1 year ago • 3 comments

@aebenson I've copied most of your non-code changes to this branch: https://github.com/pyrochlore/obsidian-tracker/compare/tracker-plus-cleanup?expand=1&w=1 Would you like to open a PR for it? I'll work on your actual code changes next

lazyguru avatar Nov 09 '23 02:11 lazyguru

Joe, I'm working through another couple rounds of refactors. If you don't have any pressing code changes, can you hold off on for a bit? I'd like to get them all in at once.

aebenson avatar Nov 09 '23 13:11 aebenson

That should be fine. Though I'd like to do the code and non-code stuff in separate PRs since the non-code stuff should be simpler to push through. The code stuff will need to be looked at a little more closely as @pyrochlore has said they may want to contribute code again in the future and I'd like to ensure the code doesn't deviate too much from the existing state without a really good reason for the change (if that makes sense?)

lazyguru avatar Nov 09 '23 17:11 lazyguru

Moving copy first works for me.

Def take a look at the code in my repo. The implementation is Obsidian is the same. The flow is the same. Things have been split up and moved around. The goal was to be able to create unit tests--under current conditions that's nearly impossible without an insane amount of spys/mocks. I'm working through the code block processor now, and still need to tackle the ui component renderers.

aebenson avatar Nov 09 '23 23:11 aebenson