pyro icon indicating copy to clipboard operation
pyro copied to clipboard

Support inference with RenyiELBO for local latent variable models

Open OlaRonning opened this issue 2 years ago • 5 comments

Addresses #3104

TODO

  • [x] Add Local latent variable model test case
  • [x] Correct RenyiELBO logsumexp reduction dim for LLV model

OlaRonning avatar Aug 02 '22 14:08 OlaRonning

Should I ignore notebooks when using black? When running black[jupyter]==22.6.0, I get 48 files changed.

OlaRonning avatar Aug 09 '22 11:08 OlaRonning

Yes could you please ignore notebooks? The easiest way to do so is to run black through make format. Alternatively we could set up a pyproject.toml file with the black exclusion list

fritzo avatar Aug 09 '22 12:08 fritzo

Yes could you please ignore notebooks?

Sure, no problem.

The easiest way to do so is to run black through make format. Alternatively we could set up a pyproject.toml file with the black exclusion list.

Looking at the format target in the Makefile, it seems it's only black that needs a section in the TOML file. I'll configure a pyproject.toml and update the Makefile.

OlaRonning avatar Aug 09 '22 15:08 OlaRonning

@martinjankowiak, can you suggest a plating structure where we need to compute the dependence (i.e., all_dims - sum_dims != num_particles_vectorized)? I've been playing around with the current implementation but cannot come up with one.

OlaRonning avatar Aug 14 '22 11:08 OlaRonning

@martinjankowiak, sorry for the late reply.

why doesn't this logic sum out the data plate dimension?

From my understanding, this corresponds to including the data plate dimension in sum_dims, or have I misunderstood something?

OlaRonning avatar Oct 12 '22 19:10 OlaRonning