numpyro icon indicating copy to clipboard operation
numpyro copied to clipboard

Fixes `random_flax_module` with `flax.linen.BatchNorm`

Open juanitorduz opened this issue 1 year ago • 1 comments

Fixes https://github.com/pyro-ppl/numpyro/issues/1446

juanitorduz avatar Jun 30 '24 20:06 juanitorduz

The first two commits are from an old branch 🤦 . We can squash and merge instead.

juanitorduz avatar Jun 30 '24 20:06 juanitorduz

image

juanitorduz avatar Jul 01 '24 15:07 juanitorduz

@fehiepsi should I leave _substitute_default_key in utils.py or is handlers.py a better place?

juanitorduz avatar Jul 01 '24 15:07 juanitorduz

Leaving it in utils sounds reasonable to me. It is just a workaround for the edge case.

Thanks for fixing the issue!

fehiepsi avatar Jul 01 '24 16:07 fehiepsi