Karthik Velayutham

Results 73 comments of Karthik Velayutham

I think Mahesh re-ran some other stuff. This seems to be failing: https://github.com/modin-project/modin/actions/runs/3048755188/jobs/4914151049

This is an interesting bug. The reason why we are not seeing `DataFrame` in globals is because it's not being imported properly. If we do import and check the type...

After investigating this a bit more I think what we are doing is not _fundamentally_ incorrect, besides the fact that we have `__reduced__` was the name for one of the...

I started a PR for this, but haven't gotten around to cleaning it up and getting it merged it. I'll try to prioritize this.

@jbrockmendel I think the `to_pandas()` call flushes out the queue so any lazy operations will get evaluated.

Haven't taken a closer look at the implementation details, but do you have any benchmarks or performance measurements to compare with master?

@jbrockmendel do you know how pandas does this? This would reduce a lot of friction for merging in code. 😄

The discussed proposal here is to automate release notes by no longer requiring the diff to be added in the PR. Instead, we use a script that sifts through the...

@anmyachev I think that's ok. In my opinion, commit messages should be concise and necessary details should always be mentioned in the description of the PR.

@anmyachev fair enough. I think there will always be some level of manual effort to put together the release notes, especially if we want more detailed groupings. However, using the...