py - Pierre Yves Ricau

Results 307 comments of py - Pierre Yves Ricau

@radityagumay I'm closing this because it sounds like you've moved on to other things, which is ok. Happy to reopen if you ever have an update.

Thank you @tommyjackson for the details and the hprof! I can reproduce locally with: ``` ./shark-cli.sh -h /Users/py/Downloads/2023-09-11_16-18-02_753.hprof analyze ==================================== HEAP ANALYSIS FAILED You can report this failure at https://github.com/square/leakcanary/issues...

> I think this leak is a false positive It's not a false positive, this is a real leak: `UserDetails` here is a parent fragment that was destroyed, `UserDetails` is...

Thanks, I do want to take a closer look, check out the branch locally, figure out why it's failing etc.

The failure has to do with the dynamic nature of WeakHashMap: the tests are adding a non retained key the map, so depending on how much work the GC is...

Updated the branch with cleanups and fixes.

We should let the broadcast receiver return before triggering the heap dump, otherwise that'll trigger an ANR as a heap dump freezes the VM.

``` import leakcanary.LeakCanary ```