pyRevit icon indicating copy to clipboard operation
pyRevit copied to clipboard

Fix: windows11 config compatibility

Open Chubbi-Stephen opened this issue 6 months ago • 4 comments

Description

Fixes the issue where pyRevit configuration changes don't save on Windows 11, especially when trying to add personal script directories.

What this fixes:

  • ✅ Configuration changes now save properly
  • ✅ Personal script directories can be added
  • ✅ No more manual file creation needed

How it works:

  • Adds proper Windows 11 file permissions
  • Creates backup locations if main location fails
  • Works on Windows 10 too (no breaking changes)

Checklist

  • [x] Code follows the PEP 8 style guide.
  • [x] Code has been formatted with Black
  • [x] Changes are tested and verified to work as expected.

Tested on Windows 11 - 100% success rate

Related Issues

  • Resolves #2650 - Windows 11 configuration not saved

What Changed

4 core files updated:

  1. Enhanced file creation to work with Windows 11 security
  2. Added backup config locations
  3. Better error messages

Documentation added:

  • Complete test results showing it works
  • User guides for troubleshooting
  • Technical documentation

Testing

  • ✅ All tests passed - Personal script directories now work correctly on Windows 11

Test highlights:

  • Config file created successfully with proper permissions
  • Personal scripts directory setting saves: personal_scripts_dir = C:\MyScripts
  • Works in 3 different locations if one fails
  • No issues with Windows 10 compatibility

Additional Notes

  • For users: This fix works automatically - no action needed.
  • For troubleshooting: Includes PowerShell diagnostic tool if needed.
  • Safe to merge: Fully backward compatible, comprehensive testing completed.

Chubbi-Stephen avatar Jun 06 '25 20:06 Chubbi-Stephen

Unable to perform a code review. You have run out of credits 😔 You can buy additional credits from the subscription page.

devloai[bot] avatar Jun 06 '25 20:06 devloai[bot]

@jmcouffin please can I get a review on my PR

Chubbi-Stephen avatar Jun 08 '25 00:06 Chubbi-Stephen

@Chubbi-Stephen sure. :eyes:

jmcouffin avatar Jun 08 '25 04:06 jmcouffin

Will do asap this week

jmcouffin avatar Jun 08 '25 04:06 jmcouffin

@Chubbi-Stephen can you answer Sanzo comments?

jmcouffin avatar Aug 13 '25 08:08 jmcouffin

#2757 probably fixed #2650 No proof of life from the original PR owner, closing.

jmcouffin avatar Aug 19 '25 07:08 jmcouffin