pyRevit icon indicating copy to clipboard operation
pyRevit copied to clipboard

Darkmode Change tab text color

Open Melleh98 opened this issue 1 year ago • 5 comments

R24 Darkmode tab text color

I just updated my toolbars to show white icons when using R24 dark mode. It works great. image image I also color coördinate my tabs so its easier to look for things. In darkmode tho the text is almost unreadable.

Ideal solutuion

The best solution for me would be to add a way to edit the text color of the tabs

Alternative solution

An alternatve could be: Being able to set a different tab color for Darkmode just like we can use PNG's just for the dark mode Icon

Melleh98 avatar Mar 07 '24 11:03 Melleh98

@dosymep Could you take a look at that?

jmcouffin avatar Mar 07 '24 17:03 jmcouffin

@Melleh98, maybe you can choose colour wich same for two modes?


background:
  title: '#31363F'

@jmcouffin, maybe add dark properties?


# set background dark for all parts
background-dark: '#ff0000' 

# or for individual dark parts
background-dark:
  panel: '#ff0000'
  title: '#00ff00'
  slideout: '#0000ff'

dosymep avatar Mar 11 '24 08:03 dosymep

@jmcouffin, maybe add dark properties?

That would make sense @dosymep Would you mind taking care of that?

jmcouffin avatar Mar 11 '24 08:03 jmcouffin

@Melleh98 following Dosymep suggestion you can set color to a middle ground color that works in both cases

https://www.notion.so/pyrevitlabs/pyRevit-Bundles-12323e3090904d9aa7cdc3d82095d3e3?pvs=4#225b2cf0dad24b0395de1930f1070ad6

# set background for all parts
background: '#ff0000'                   # or ARGB e.g. #ff0000ff

# or for individual parts
background:
  panel: '#ff0000'
  title: '#00ff00'
  slideout: '#0000ff'

jmcouffin avatar Mar 11 '24 08:03 jmcouffin

@dosymep or maybe just have a text-color-dark attribute to just change the text color?

jmcouffin avatar Mar 11 '24 09:03 jmcouffin

"👋 Hi there! It looks like there hasn't been any activity on this issue for the past 60 days. We understand that things can get busy. Just a friendly reminder that this issue is scheduled to be automatically closed in 14 days if there's no further activity. If you still need assistance or have additional information to share, please feel free to comment, and we'll be happy to help! 🚀 Thanks for your understanding!"

github-actions[bot] avatar May 11 '24 02:05 github-actions[bot]

This issue was closed because it has been inactive for 14 days since being marked as stale.

github-actions[bot] avatar May 25 '24 02:05 github-actions[bot]