pyrad icon indicating copy to clipboard operation
pyrad copied to clipboard

Published 20 hours ago • verified publisher icon pyradius

VerifyAcctRequest documentation is misleading

Open tardate opened this issue 9 years ago • 0 comments
trafficstars

VerifyAcctRequest doc says it returns True if verification failed: https://github.com/wichert/pyrad/blob/master/pyrad/packet.py#L490

This seems contrary to expectations, and I think contrary to the test assertions: https://github.com/wichert/pyrad/blob/master/pyrad/tests/testPacket.py#L393

So it seems the doc is wrong? I can submit a PR for it, but wanted to ask first since a doc change might sneak past without breaking any tests. Maybe I'm reading the code wrong?

tardate avatar Jun 23 '16 04:06 tardate