unilog icon indicating copy to clipboard operation
unilog copied to clipboard

Published 20 hours ago • verified publisher icon pyr

Adding filter support to all appenders implementing UnsynchronizedAppenderBase

Open RolT opened this issue 5 years ago • 1 comments

Hi,

I'm not sure how to implement filter support as an extension on my side. The way I did it was to implement the build-appender and the start-appender! function for every type of appender I want to use. I feel like adding it to the library makes it simpler.

Would you be interested in that PR ? I could also add the filter instantiation in the build-appender method if you prefer.

What do you think ?

RolT avatar Mar 18 '19 14:03 RolT

The build is passing for oraclejdk8 and openjdk7. The failing part is installing oraclejdk7:

install-jdk.sh 2019-01-18 II
Expected feature release number in range of 9 to 13, but got: 7

RolT avatar Mar 26 '19 10:03 RolT