pyproj icon indicating copy to clipboard operation
pyproj copied to clipboard

DOC: add note for WKT and CRS interaction

Open myl-dvl opened this issue 7 months ago • 6 comments

  • [x] Closes #1486

image


It seems that it added my previous commits, I'm not sure what I did wrong. Does it change anything for the PR ?

myl-dvl avatar Apr 25 '25 14:04 myl-dvl

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.56%. Comparing base (6a38287) to head (8ff8133). Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1490      +/-   ##
==========================================
+ Coverage   96.50%   96.56%   +0.05%     
==========================================
  Files          20       20              
  Lines        1830     1832       +2     
==========================================
+ Hits         1766     1769       +3     
+ Misses         64       63       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Apr 25 '25 14:04 codecov[bot]

Probably helpful to note here that WKT doesn't work on import for CoordinateSystem and PROJ JSON is preferred: https://github.com/pyproj4/pyproj/blob/1fa11649f7f0adeda5ec4ad1e778bbea7dd6bf0b/pyproj/_crs.pyx#L514

snowman2 avatar Apr 25 '25 15:04 snowman2

Probably helpful to note here that WKT doesn't work on import for CoordinateSystem and PROJ JSON is preferred:

https://github.com/pyproj4/pyproj/blob/1fa11649f7f0adeda5ec4ad1e778bbea7dd6bf0b/pyproj/_crs.pyx#L514


Something like this ?

image

myl-dvl avatar Apr 27 '25 11:04 myl-dvl

Something like this ?

Yes, that would be great to add to from_user_input.

snowman2 avatar Apr 30 '25 01:04 snowman2

Something like this ?

Yes, that would be great to add to from_user_input.

I'm not sure if you want the note here or in this method (link). Could you elaborate please ? I will undraft this PR, if by luck it works for you^^

myl-dvl avatar May 03 '25 17:05 myl-dvl

The original issue #1485 had confusion as the user was using from_user_input. So, I think that it would be good to ensure that we add a note inside that method. You can also have a note where you have it as well as someone may see it there instead.

snowman2 avatar May 05 '25 11:05 snowman2