polestar_api icon indicating copy to clipboard operation
polestar_api copied to clipboard

Split API functionality into a separate library

Open dgomes opened this issue 1 year ago • 3 comments

In order for this integration to become an official HA integration all API call must be moved into a separate python library published on pypi

I propose the creation of library pypolestar in a separate repository and that best practices such as those in https://github.com/pyenphase/pyenphase are followed

dgomes avatar Dec 19 '23 18:12 dgomes

I agree. I'd be happy to help setting up the infrastructure if needed.

jschlyter avatar Dec 20 '23 07:12 jschlyter

@leeyuentuen I think there are already a couple devs available to work on this, would you care to create a repository or delegate in one of us the task ? maybe creating a GitHub organisation to manage the library + custom_integration ?

dgomes avatar Dec 20 '23 16:12 dgomes

i need to find it out how that stuff works. atm create a GitHub pypolestar: https://github.com/leeyuentuen/pypolestar on PyPI I've created a pending project: image

leeyuentuen avatar Dec 20 '23 19:12 leeyuentuen

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] avatar Nov 13 '24 02:11 github-actions[bot]

xref https://github.com/leeyuentuen/pypolestar/issues/9

jschlyter avatar Nov 25 '24 07:11 jschlyter

things are looking real good in the current custom_integration.

Pushing the release of the separate library would enable the work in an initial PR to HA core with limited functionality (we don't want to feature creep reviewers, a simple PR will get better chances of being reviewed quicker)

dgomes avatar Dec 25 '24 19:12 dgomes

Splitting to a separate library is pending on https://github.com/pypolestar/pypolestar/issues/10, waiting on action from @leeyuentuen (nudge, nudge)

jschlyter avatar Dec 25 '24 22:12 jschlyter

https://github.com/pypolestar/pypolestar now up to date, will do some cleanup before publishing a new version

jschlyter avatar Dec 31 '24 14:12 jschlyter

https://github.com/pypolestar/pypolestar now updated on PyPI.

jschlyter avatar Jan 11 '25 08:01 jschlyter