warehouse icon indicating copy to clipboard operation
warehouse copied to clipboard

Add links to corresponding resources into the email notification when receiving access to packages

Open webknjaz opened this issue 6 years ago • 6 comments

What's the problem this feature will solve?

I received this email recently:

You have been added as {{role}} to the PyPI project {{project_name}} by {{other_user}}.

—
You are receiving this because you have been added by {{other_user}} to a project on PyPI.

But there's not a single link in it. So if I were to open a role explanation on the help page, the project page or the user page, I'd have to type/search/copy things, which is not a good UX.

Describe the solution you'd like

I just want to have clickable things in that email.

Additional context

Corresponding templates:

  • https://github.com/pypa/warehouse/blob/97c4a5124e86119eabe57c7b896a34d2732dc1d0/warehouse/templates/email/added-as-collaborator/body.html
  • https://github.com/pypa/warehouse/blob/97c4a5124e86119eabe57c7b896a34d2732dc1d0/warehouse/templates/email/added-as-collaborator/body.txt

webknjaz avatar Sep 22 '19 19:09 webknjaz

cc @aram-cinnamon we chatted about this - let me know if you need more pointers!

miketheman avatar May 16 '24 17:05 miketheman

i can do it using ahref like this just assign me for this one You have been added as <a href="https://pypi.org/help/#{{role}}">{{role}}</a> to the PyPI project <a href="https://pypi.org/project/{{project_name}}/">{{project_name}}</a> by <a href="https://pypi.org/user/{{other_user}}/">{{other_user}}</a>

CoderLogy avatar Sep 03 '24 08:09 CoderLogy

@CoderLogy We do not assign issues to folks outside the organization, but if you'd like to put up a PR to resolve, please do so! Read the contributing details in https://warehouse.pypa.io/development/index.html and specifically the notes about Emails: https://warehouse.pypa.io/development/email.html and Translations: https://warehouse.pypa.io/development/submitting-patches.html#translations

miketheman avatar Sep 03 '24 13:09 miketheman

@CoderLogy We do not assign issues to folks outside the organization, but if you'd like to put up a PR to resolve, please do so!

Read the contributing details in https://warehouse.pypa.io/development/index.html

and specifically the notes about Emails: https://warehouse.pypa.io/development/email.html

and Translations: https://warehouse.pypa.io/development/submitting-patches.html#translations

How can I join this organization.

CoderLogy avatar Sep 03 '24 20:09 CoderLogy

@CoderLogy you don't have to. You can go ahead and open a PR right away if you're interested in working on this.

webknjaz avatar Sep 04 '24 08:09 webknjaz

Ok Thnks for letting me know, on my way to pr

CoderLogy avatar Sep 04 '24 11:09 CoderLogy

Since the last activity on this issue was on September 4 and the isssue is still open, I am trying to work on this to create a PR. (DISCLAIMER: I am new to open source contributions)

VineetHBhat avatar Oct 26 '24 15:10 VineetHBhat