warehouse icon indicating copy to clipboard operation
warehouse copied to clipboard

Published 20 hours ago • verified publisher icon pypi

Trusted publishing: surface pending publisher name collisions

Open twm opened this issue 1 year ago • 4 comments

Provide up-front validation of the project name within a pending publisher by:

  • Extracting the validation logic from ProjectService.create_project to a new ProjectService.check_project_name routine
  • Update ProjectService.create_project to call check_project_name
  • Thread ProjectService into the forms in place of ProjectFactory.

Fixes #16226.

twm avatar Jul 11 '24 01:07 twm

Hey @twm, FYI our general policy is to not review draft PRs unless explicitly asked -- let us know if you have any questions here, otherwise we will wait for this to become ready to review.

di avatar Jul 11 '24 19:07 di

Hi @di, thanks for approving the build! Some connectivity issues are making it difficult to get things working locally so it's very helpful. I'll remove the draft status when I'm ready for review!

twm avatar Jul 13 '24 05:07 twm

Hi @di, this is ready again. I'd appreciate a review within a few days if you can, as I keep having to rebase through conflicts.

twm avatar Aug 20 '24 18:08 twm

Hi @di, sorry for losing track of this. I've addressed your comment and merged forward.

twm avatar Sep 22 '24 18:09 twm

Hi @di, thank you for the review! I've rebased the migration here again. The Dependencies build failure appears unrelated to these changes.

twm avatar Dec 02 '24 03:12 twm

Thanks for your patience here @twm!

di avatar Dec 02 '24 23:12 di