warehouse icon indicating copy to clipboard operation
warehouse copied to clipboard

Initial implementation of GitLab statistics

Open nE0sIghT opened this issue 1 year ago • 2 comments

Issue: https://github.com/pypi/warehouse/issues/12789

nE0sIghT avatar May 09 '24 20:05 nE0sIghT

Thanks for the PR! It looks great, but I'm going to hold off on fully reviewing/merging this until #8635 is resolved for GitLab URLs, so we don't run into the same issue as we have for GitHub.

di avatar Jul 03 '24 15:07 di

#16205 looks good! I will follow it and work on Gitlab part if needed

nE0sIghT avatar Jul 03 '24 15:07 nE0sIghT

Hello!

Do I need to rebase this PR or either merge main branch here?

nE0sIghT avatar Aug 13 '24 07:08 nE0sIghT

@nE0sIghT Hang tight, I suspect the next part of https://github.com/pypi/warehouse/issues/8635 that we will resolve will be verifying the GitHub statistics, after which we can get this up to date. Thanks for your patience!

di avatar Aug 13 '24 20:08 di

Could we proceed with this PR? I can rebase or merge main branch here

nE0sIghT avatar Sep 10 '24 18:09 nE0sIghT

Sorry, I meant to comment here that this is unblocked now that https://github.com/pypi/warehouse/pull/16532 is merged. Please feel free to proceed!

di avatar Sep 10 '24 18:09 di

Thanks! Should I merge or rebase?

nE0sIghT avatar Sep 10 '24 19:09 nE0sIghT

Either is fine, we do squash merging so it doesn't make much difference.

di avatar Sep 10 '24 19:09 di

I rebased PR on top of the main branch, added unit tests and tested locally

image

nE0sIghT avatar Sep 10 '24 21:09 nE0sIghT

Thanks for review! I pushed new commits that should address mentioned issues.

nE0sIghT avatar Sep 17 '24 17:09 nE0sIghT

@nE0sIghT Can you resolve the merge conflicts here? Thanks

di avatar Sep 18 '24 21:09 di

Can you resolve the merge conflicts here?

It's done

nE0sIghT avatar Sep 19 '24 05:09 nE0sIghT

project-data.html in the message.pot is popular :-) Should I merge main branch again?

nE0sIghT avatar Sep 19 '24 14:09 nE0sIghT

Sorry, we have been sorting out some issues there recently :) Yes please, should be the last time!

di avatar Sep 19 '24 18:09 di