warehouse
warehouse copied to clipboard
Initial implementation of GitLab statistics
Issue: https://github.com/pypi/warehouse/issues/12789
Thanks for the PR! It looks great, but I'm going to hold off on fully reviewing/merging this until #8635 is resolved for GitLab URLs, so we don't run into the same issue as we have for GitHub.
#16205 looks good! I will follow it and work on Gitlab part if needed
Hello!
Do I need to rebase this PR or either merge main branch here?
@nE0sIghT Hang tight, I suspect the next part of https://github.com/pypi/warehouse/issues/8635 that we will resolve will be verifying the GitHub statistics, after which we can get this up to date. Thanks for your patience!
Could we proceed with this PR? I can rebase or merge main branch here
Sorry, I meant to comment here that this is unblocked now that https://github.com/pypi/warehouse/pull/16532 is merged. Please feel free to proceed!
Thanks! Should I merge or rebase?
Either is fine, we do squash merging so it doesn't make much difference.
I rebased PR on top of the main branch, added unit tests and tested locally
Thanks for review! I pushed new commits that should address mentioned issues.
@nE0sIghT Can you resolve the merge conflicts here? Thanks
Can you resolve the merge conflicts here?
It's done
project-data.html in the message.pot is popular :-) Should I merge main branch again?
Sorry, we have been sorting out some issues there recently :) Yes please, should be the last time!