warehouse
warehouse copied to clipboard
pypi
Document the project and file upload limits in pypi on the FAQ page
This is for #6192 . I had to create a new constants module because import warehouse.legacy leads to circular imports. Instead of resolving that, I went with creating a new file
Test Plan: make build, make initdb, make serve and read http://localhost/help/#project-size-limit .
This is how it looks like:
Fixes #6192.
From https://github.com/pypi/warehouse/issues/6192#issuecomment-1372724774:
I'd prefer using the variables to control the output so as to prevent drift between the values and the docs.
I think I agree, these variables can be found here: https://github.com/pypi/warehouse/blob/281447fc54f5d51778551c3734fd1daa0cde63e7/warehouse/forklift/legacy.py#L78-L80
@di , updated the PR. Thanks for the suggestion. Please review if you have cycles
Does anyone know why this is awaiting response? This should be ready for review
Hi @SurenNihalani, are you able to resolve the conflicts here and address the review so we can merge this? Thanks!
Two questions:
- When I look on a project's settings page I see something like the following:
Note the use of binary multiple-byte units, i.e. MiB and GiB. Shouldn't the FAQ entry use the same units?
- Isn't the FAQ entry describing generic limits? I.e. it can't describe any higher limits granted to a specific project because the FAQ doesn't have that context. If that's the case, then I think it should say something like
... hiting the upload file size limit (100 MiB by default; individual projects may have limit overrides)
I don't want to step on @SurenNihalani 's toes, but I'm looking for a good first issue to work on so I'll see if I can resolve those conflicts and make those changes.
I think that's fine @warsaw, it seems like this has been abandoned (if you can pull in @SurenNihalani's previous commits to your PR so they get credit, that would be awesome).
Sounds good @di. I've branched @SurenNihalani 's original PR and am trying to merge main to resolve conflicts. If that doesn't hurt my brain too much, I'll push a new branch + new PR on top of the original one.
@di One conflict I'm not sure how to resolve is on warehouse/locale/messages.pot and this documentation page doesn't make it clear how the pot files is generated. Can you explain the right workflow for that?
@warsaw See https://warehouse.pypa.io/development/submitting-patches.html#translations.